Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract GetManifestGeneratePaths() and add tests #663

Merged
merged 1 commit into from
Jun 25, 2022
Merged

refactor: extract GetManifestGeneratePaths() and add tests #663

merged 1 commit into from
Jun 25, 2022

Conversation

int128
Copy link
Owner

@int128 int128 commented Jun 25, 2022 •
edited
Loading

Follow up #656.

This extracts GetManifestGeneratePaths() function and adds tests.

@int128 int128 changed the title refactor: extract GetManifestGeneratePaths() and add tests refactor: extract GetManifestGeneratePaths() and add tests Jun 25, 2022
This was referenced Jun 25, 2022
Merged
Merged
@github-actions
Copy link
Contributor

❌ Failed to deploy pr-663/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

@int128 int128 force-pushed the int128/test-manifestGeneratePaths branch from 71d585a to ee4e360 Compare June 25, 2022 07:21
This was referenced Jun 25, 2022
Merged
Merged
@github-actions
Copy link
Contributor

❌ Failed to deploy pr-663/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

@int128 int128 force-pushed the int128/test-manifestGeneratePaths branch from ee4e360 to d76e4ab Compare June 25, 2022 07:37
This was referenced Jun 25, 2022
Merged
Merged
@github-actions
Copy link
Contributor

❌ Failed to deploy pr-663/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

@int128 int128 force-pushed the int128/test-manifestGeneratePaths branch from d76e4ab to d80ae3b Compare June 25, 2022 07:53
This was referenced Jun 25, 2022
Merged
Merged
@github-actions
Copy link
Contributor

❌ Failed to deploy pr-663/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

@int128 int128 force-pushed the int128/test-manifestGeneratePaths branch from d80ae3b to d2ca388 Compare June 25, 2022 08:15
@int128 int128 force-pushed the int128/test-manifestGeneratePaths branch from d2ca388 to 878a018 Compare June 25, 2022 08:36
@int128 int128 marked this pull request as ready for review June 25, 2022 08:36
This was referenced Jun 25, 2022
Merged
Merged
@github-actions
Copy link
Contributor

❌ Failed to deploy pr-663/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

@int128 int128 merged commit 4cb7d29 into master Jun 25, 2022
@int128 int128 deleted the int128/test-manifestGeneratePaths branch June 25, 2022 08:44
@github-actions
Copy link
Contributor

❌ Failed to deploy master/app2

Failed:
one or more objects failed to apply, reason: Deployment.apps "echoserver" is invalid: spec.selector: Invalid value: v1.LabelSelecto
https://argocd.example.com/applications/app2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy/master/app2/failure deploy/pr-663/app2/failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@int128